gh-155864: Keep the module's current screen in step with use_screen() - #155865
Merged
serhiy-storchaka merged 1 commit intoAug 16, 2026
Merged
Conversation
…reen() screen.use() makes its screen current for the callback, but the module kept recording the previously current screen, so newwin(), newpad() and getwin() tagged the new window with the wrong owner. The window then failed to keep its own screen alive: the screen could be freed while the window was still in use, and the next call on it read freed memory. initscr() inside use() returned the other screen's standard window for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point
state->topscreenat the used screen for the duration of thescreen.use()callback and restore it afterwards, which is whatuse_screen()itself does aroundset_term(). Add regression tests for the window ownership and forinitscr()insideuse().The restore also undoes a
set_term()performed inside the callback, which ncurses already reverts but the module did not.No NEWS entry:
newterm()andscreen.use()are new in 3.16 and unreleased.curses.screen.use()#155864